Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing license (needs signoff from all contributors) #272

Merged
4 commits merged into from
Feb 28, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Feb 27, 2024

Description

We made a mistake. This repository contains no LICENSE file, which makes it all rights reserved by default. This PR fixes the missing license in this repository. It also changes the background to one unencumbered by non-F/OSS licenses.

Required reviews

Since this is a license change, we must either obtain a review / approval from the following people or remove their contributions to merge this PR.

Motivation and Context

There is no license, which makes the repository all rights reserved by default.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Copy link

cloudflare-workers-and-pages bot commented Feb 27, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c10c3de
Status: ✅  Deploy successful!
Preview URL: https://ff2137dc.opentofu.pages.dev
Branch Preview URL: https://license-fix.opentofu.pages.dev

View logs

@rdhar
Copy link
Contributor

rdhar commented Feb 27, 2024

Sure, no problem, happy to approve. I missed this as well!

Could you please add the listed people as reviewers for this PR so it becomes as easy as 2 clicks to gather approval?

Copy link
Contributor

@rdhar rdhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Janos Bonic <[email protected]>
@ghost
Copy link
Author

ghost commented Feb 27, 2024

@Yantrio @damianstasik @xuoe @Sirivasv @bencurio @rdhar @jakubabrzy sorry, this seems to be an error-prone issue, the license file was actually empty. Please approve again. (Sorry, sorry, sorry.)

@ghost ghost requested review from damianstasik and Sirivasv February 27, 2024 08:49
@Yantrio Yantrio requested a review from cube2222 February 27, 2024 08:52
@ghost
Copy link
Author

ghost commented Feb 27, 2024

@rdhar sadly, I can only add people to issues who are either a participant on the repo or in the org. However, I reached out to everyone individually to make sure we get all reviews in. Thanks for the help everyone!

@IgnorantSapient
Copy link
Contributor

Hey @janosdebugs could you request a review from me please?

@ghost
Copy link
Author

ghost commented Feb 27, 2024

@IgnorantSapient I can't because there's an upper limit on the number of reviewers, but you should just be able to review the PR on your own.

image

Copy link
Contributor

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdhar
Copy link
Contributor

rdhar commented Feb 28, 2024

All done, and within 26 hours or so -- not bad, eh!

image

@ghost ghost merged commit 1f52b37 into main Feb 28, 2024
3 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.