-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing missing license (needs signoff from all contributors) #272
Conversation
Signed-off-by: Janos Bonic <[email protected]>
Deploying with Cloudflare Pages
|
Sure, no problem, happy to approve. I missed this as well! Could you please add the listed people as reviewers for this PR so it becomes as easy as 2 clicks to gather approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Janos Bonic <[email protected]>
@Yantrio @damianstasik @xuoe @Sirivasv @bencurio @rdhar @jakubabrzy sorry, this seems to be an error-prone issue, the license file was actually empty. Please approve again. (Sorry, sorry, sorry.) |
Signed-off-by: Janos Bonic <[email protected]>
Signed-off-by: Janos Bonic <[email protected]>
@rdhar sadly, I can only add people to issues who are either a participant on the repo or in the org. However, I reached out to everyone individually to make sure we get all reviews in. Thanks for the help everyone! |
Hey @janosdebugs could you request a review from me please? |
@IgnorantSapient I can't because there's an upper limit on the number of reviewers, but you should just be able to review the PR on your own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
We made a mistake. This repository contains no LICENSE file, which makes it all rights reserved by default. This PR fixes the missing license in this repository. It also changes the background to one unencumbered by non-F/OSS licenses.
Required reviews
Since this is a license change, we must either obtain a review / approval from the following people or remove their contributions to merge this PR.
Motivation and Context
There is no license, which makes the repository all rights reserved by default.
Screenshots (if appropriate):
Types of changes
Checklist: